mirrors/disposable-email-domains
1
0
Fork 0
mirror of https://github.com/disposable-email-domains/disposable-email-domains.git synced 2024-11-25 18:18:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improvements for the Python example code (#329)

Browse Source 
* docs(readme): Fix missing `open()` in Python example code

* docs(readme): Use set instead of list in Python example code

This reduces the computational complexity of a list lookup from O(n) to
O(1).

* docs(readme): Replace `split()` with `partition()` in Python example

The will always work and never throw an exception, even if `email` is
in fact not a valid email address or doesn't contain an `@` character at
all. It also prevents unexpected behavior if `email` contains multiple
`@` signs, i.e.:

| `email`       | Lookup Before | Lookup After  |
| ------------- | ------------- | ------------- |
| 'foo@bar'     | 'bar'         | 'bar'         |
| 'foo@bar@baz' | 'bar'         | 'bar@baz'     |
| 'foo'         | *Exception*   | ''            |
This commit is contained in:
Jan Holthuis 2022-08-02 21:22:22 +02:00 committed by GitHub
parent 2258b1b6f9
commit f3fa1f0720
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
README.md
View File

@ -15,9 +15,9 @@ Example Usage
============= =============
**Python** **Python**
```Python ```Python
blocklist = ('disposable_email_blocklist.conf') with open('disposable_email_blocklist.conf') as blocklist:
blocklist_content = [line.rstrip() for line in blocklist.readlines()] blocklist_content = {line.rstrip() for line in blocklist.readlines()}
if email.split('@')[1] in blocklist_content: if email.partition('@')[2] in blocklist_content:
message = "Please enter your permanent email address." message = "Please enter your permanent email address."
return (False, message) return (False, message)
else: else: