mirrors/quickjs
1
0
Fork 0
mirror of https://github.com/bellard/quickjs.git synced 2024-11-22 21:58:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix test262 error

Browse Source 
- force evaluation order in `set_date_fields`
- fix evaluation error in test262/test/built-ins/Date/UTC/fp-evaluation-order.js:19:
  unexpected error: Test262Error: precision in MakeDate Expected SameValue(«34448384», «34447360») to be true
This commit is contained in:
Charlie Gordon 2024-02-12 18:37:37 +01:00
parent ef4e7b23f4
commit 1fe04149e9
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
quickjs.c
View File

@ -49431,7 +49431,8 @@ static double time_clip(double t) {
of the operations */ of the operations */
static double set_date_fields(double fields[], int is_local) { static double set_date_fields(double fields[], int is_local) {
int64_t y; int64_t y;
double days, d, h, m1; double days, h, m1;
volatile double d; /* enforce evaluation order */
int i, m, md; int i, m, md;
m1 = fields[1]; m1 = fields[1];
@ -49448,9 +49449,14 @@ static double set_date_fields(double fields[], int is_local) {
days += md; days += md;
} }
days += fields[2] - 1; days += fields[2] - 1;
/* made d volatile to ensure order of evaluation as specified in ECMA.
* this fixes a test262 error on
* test262/test/built-ins/Date/UTC/fp-evaluation-order.js
*/
h = fields[3] * 3600000 + fields[4] * 60000 + h = fields[3] * 3600000 + fields[4] * 60000 +
fields[5] * 1000 + fields[6]; fields[5] * 1000 + fields[6];
d = days * 86400000 + h; d = days * 86400000;
d = d + h;
if (is_local) if (is_local)
d += getTimezoneOffset(d) * 60000; d += getTimezoneOffset(d) * 60000;
return time_clip(d); return time_clip(d);