mirrors/quickjs
1
0
Fork 0
mirror of https://github.com/bellard/quickjs.git synced 2024-11-22 21:58:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

added a comment for non-initialized warning in Valgrind (github issue #153)

Browse Source
This commit is contained in:
Fabrice Bellard 2024-01-06 11:20:20 +01:00
parent 3ab1c2b314
commit bd0b7048de
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
quickjs.c
View File

@ -7899,6 +7899,16 @@ static JSValue JS_GetPropertyValue(JSContext *ctx, JSValueConst this_obj,
/* fast path for array access */ /* fast path for array access */
p = JS_VALUE_GET_OBJ(this_obj); p = JS_VALUE_GET_OBJ(this_obj);
idx = JS_VALUE_GET_INT(prop); idx = JS_VALUE_GET_INT(prop);
/* Note: this code works even if 'p->u.array.count' is not
initialized. There are two cases:
- 'p' is an array-like object. 'p->u.array.count' is
initialized so the slow_path is taken when the index is
out of bounds.
- 'p' is not an array-like object. 'p->u.array.count' has
any value and potentially not initialized. In all the cases
(idx >= len or idx < len) the slow path is taken as
expected.
*/
len = (uint32_t)p->u.array.count; len = (uint32_t)p->u.array.count;
if (unlikely(idx >= len)) if (unlikely(idx >= len))
goto slow_path; goto slow_path;